git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Makefile: Add NEEDS_CRYPTO_WITH_SSL

From
Brian Gernhardt <brian@gernhardtsoftware.com>
Date
Aug 24, 2009, 14:22 UTC
Message-ID
<4E04F1F2-132A-4695-BCFF-C1F3159671AF@gernhardtsoftware.com>
In-Reply-To
<81b0412b0908240245l33b04322l923084362197406a@mail.gmail.com>
On Aug 24, 2009, at 5:45 AM, Alex Riesen wrote:
> As imap-send is the only one which uses the symbols, why not just add
> LIB_4_CRYPTO
> to its linking command? Like in the broken GMail-patch below:

I didn't do this because I didn't know if all platforms needed libcrypto to compile imap-send. If it is, then this is obviously the simpler solution.

Show 13 quoted lines
> diff --git a/Makefile b/Makefile
> index 02ff867..33971f3 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1503,7 +1503,7 @@ git-%$X: %.o $(GITLIBS)
>
> git-imap-send$X: imap-send.o $(GITLIBS)
> 	$(QUIET_LINK)$(CC) $(ALL_CFLAGS) -o $@ $(ALL_LDFLAGS) $(filter %.o, 
> $^) \
> -		$(LIBS) $(OPENSSL_LINK) $(OPENSSL_LIBSSL)
> +		$(LIBS) $(OPENSSL_LINK) $(OPENSSL_LIBSSL) $(LIB_4_CRYPTO)
>
> http.o http-walker.o http-push.o: http.h
Previous: Alex Riesen
Message 3 of 3 in “Makefile: Add NEEDS_CRYPTO_WITH_SSL”
  1. Makefile: Add NEEDS_CRYPTO_WITH_SSLBrian Gernhardt, Aug 15, 2009
  2. Alex RiesenAug 24, 2009
  3. Brian GernhardtAug 24, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.