Re: [PATCH] stash: Add --clean option to stash and remove all untracked files

From: Andrew Wong <andrew.w@sohovfx.com>
Date: Jun 21, 2011, 05:08 UTC
Message-ID: <4E002762.3050803@sohovfx.com>
In-Reply-To: <4DFFF5AA.4030401@porkrind.org>

Ah, this patch will be very useful. I actually ran into several scenarios before where I wished stash could do exactly this.

On 11-06-20 9:36 PM, David Caldwell wrote:

Show 10 quoted lines

> On 6/20/11 5:38 PM, Jeff King wrote:
>> Hmm. I think I would call this something like "--untracked", as to me
>> the main function is saving those files, not cleaning them afterwards
>> (the fact that they are cleaned is really just making the untracked-file
>> handling in line with what we do for tracked files; we put the changes
>> in the stash and remove them from the working tree).
>
> I see your point but I thought "--clean" was pretty descriptive of how
> the working dir ended up afterward. Maybe "git stash --everything" (or
> "--all")?

I personally think "--untracked" (and -u) is more intuitive too, since it tells you what "git stash" is about to do. i.e. "git stash" is about to do the usual stash operation *and* also stash the "untracked" files. It seems more clear and precise than saying "git will stash my tree to a state that is clean", which doesn't exactly tell me how is that different from the usual stash.To me, "--clean" might even sounds more like "do a stash, and then do a clean", which doesn't make sense.

I would've liked "--all" too, except it reminds me too much of "git commit --all", which is just committing all tracked files.

Again, that's just my personal preference.