git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] config.c: Remove unused git_config_global() function

From
Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Date
May 31, 2011, 17:23 UTC
Message-ID
<4DE5241E.9030000@ramsay1.demon.co.uk>

Commit 8f323c00 (drop support for GIT_CONFIG_NOGLOBAL, 15-03-2011) removed the git_config_global() function, among other things, since it is no longer required. Unfortunately, this function has since been unintentionally restored; I suspect by merge commit 25b86e45 (Merge branch 'jk/maint-config-alias-fix' into next, 25-05-2011).

Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
---
Hi Junio,

A few days ago, when the next branch was @ d10669c, I noticed that "make sparse" on next was complaining thus:

    config.c:828:5: warning: symbol 'git_config_global' was not \
        declared. Should it be static?

However, I remembered that this function had recently been removed, so I took a quick look ...

ATB, Ramsay Jones

 config.c |    5 -----
 1 files changed, 0 insertions(+), 5 deletions(-)
diff --git a/config.c b/config.c
index a8267e9..e0b3b80 100644
--- a/config.c
+++ b/config.c
@@ -825,11 +825,6 @@ int git_config_system(void)
 	return !git_env_bool("GIT_CONFIG_NOSYSTEM", 0);
 }
 
-int git_config_global(void)
-{
-	return !git_env_bool("GIT_CONFIG_NOGLOBAL", 0);
-}
-
 int git_config_early(config_fn_t fn, void *data, const char *repo_config)
 {
 	int ret = 0, found = 0;
-- 
1.7.5
Next: Junio C Hamano
Message 1 of 5 in “config.c: Remove unused git_config_global() function”
  1. config.c: Remove unused git_config_global() functionRamsay Jones, May 31, 2011
  2. Junio C HamanoMay 31, 2011
  3. Effectively navigating branch history (was: Re: [PATCH] config.c: Remove unused git_config_global() function)Stephen Bash, May 31, 2011
  4. Junio C HamanoMay 31, 2011
  5. Stephen BashMay 31, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.