Re: Why does adding an existing repo as a submodule modify .git/config?

From: Jens Lehmann <jens.lehmann@web.de>
Date: May 26, 2011, 21:35 UTC
Message-ID: <4DDEC795.3030304@web.de>
In-Reply-To: <BANLkTingA2oRY4i6OnYSz8PGdTRDqXVdFw@mail.gmail.com>

Am 25.05.2011 05:11, schrieb Christopher Wilson:

Show 8 quoted lines

> On Tue, May 24, 2011 at 6:06 PM, Mark Levedahl <mlevedahl@gmail.com> wrote:
> 
>> However, while you could then change submodule-add to not register the
>> submodule, you would now have the condition of having a submodule that is
>> checked out in the current tree but *not* registered in .git/config.
> 
> Isn't this exactly what "git submodule add" currently does for
> submodules that are NOT added in place?

That is the inconsistency this thread is about. Thanks Christopher for bringing that up and to Mark for explaining the rationale for updating the url in .git/config. I really agree with what Mark said there and also concur with Christopher that a "git submodule add" should always update the url in .git/config, no matter if it is an already existing repo being added or a freshly cloned one.

But unfortunately there is more to it than just adding a
	git config submodule."$path".url "$realrepo"
to the module_clone branch in cmd_add() because that makes tests break
where "git submodule init" doesn't copy the "update" settings into
.git/config anymore as it already finds an url configured there and
thinks there is nothing to do. I'm looking into fixing that right now,
so stay tuned ...