git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[RFC PATCH 0/2] better handle .gitmodules merge conflicts

From
Jens Lehmann <jens.lehmann@web.de>
Date
May 12, 2011, 21:01 UTC
Message-ID
<4DCC4A9D.3060007@web.de>

This series contains a test to reproduce and a first attempt to fix the problem that "git diff", "git status" and "git fetch" die early when the .gitmodules file contains merge conflict markers. As I am not aware of any bug reports yet it looks like that either doesn't happen very often in the wild ("git diff" parses the .gitmodules file since 1.7.3, but even as heavy submodule users we only hit this once just recently) or the users encountering this problem just know what to do: resolve the conflict and carry on.

But that is no excuse to behave so unfriendly, especially as this can happen in a completely normal workflow, when e.g. two users are adding different submodules in separate branches and they get merged. So this RFC patch is my first attempt to avoid those commands dying.

In a second step a merge helper capable of merging inifiles would make sense. This should be enabled for the .gitmodules file by default and avoid most of the merge conflicts, e.g. when two users add different submodules in separate branches. But that is a different patch ...

Heiko Voigt (1):
  test that git status works with merge conflict in .gitmodules
Jens Lehmann (1):
  Submodules: Don't parse .gitmodules when it contains merge conflicts
 submodule.c                 |   23 +++++++++-
 t/t7506-status-submodule.sh |  100 +++++++++++++++++++++++++++++++++++++++++--
 2 files changed, 117 insertions(+), 6 deletions(-)
-- 
1.7.5.1.251.ga75dd
Next: Jens Lehmann
Message 1 of 6 in “better handle .gitmodules merge conflicts”
  1. 0/2 better handle .gitmodules merge conflictsJens Lehmann, May 12, 2011
  2. 1/2 test that git status works with merge conflict in .gitmodulesJens Lehmann, May 12, 2011
  3. Junio C HamanoMay 13, 2011
  4. 2/2 Submodules: Don't parse .gitmodules when it contains merge conflictsJens Lehmann, May 12, 2011
  5. Junio C HamanoMay 13, 2011
  6. Marc BranchaudMay 13, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.