Re: [PATCH] staging: brcm80211: SDIO/MMC cleanups
- From
- Arend van Spriel <arend@broadcom.com>
- Date
- May 6, 2011, 16:44 UTC
- Message-ID
- <4DC42562.5080308@broadcom.com>
- In-Reply-To
- <7v39kr3j8r.fsf@alter.siamese.dyndns.org>
On 05/06/2011 06:07 PM, Junio C Hamano wrote:
Show 17 quoted lines
> Michael J Gruber<git@drmicha.warpmail.net> writes: > >> Junio C Hamano venit, vidit, dixit 06.05.2011 16:37: >>> "Arend van Spriel"<arend@broadcom.com> writes: >>> >>>> The git documentation on the git am command is not very elaborate. I >>>> investigated the issue and checked following: >>>> 1. line 135 in dhd_sdio.c in the patch does match line 135 in my >>>> checked out branch. >>> Does it exactly match, or does it merely visually match if you ignore tabs >>> and spaces munged by somebody between the state of the file submitter >>> committed and grunder.eml file you stored? >> Junio, he reported the hashes to match! Puzzling. Or a MUA doing things >> to the .eml. > The latter is exactly what I meant. The mailchain leading to the > receiver's mailbox would not adjust the hash recorded in the patch when it > munges whitespaces.
Tried patch -p1 < grundler.eml. That gives info at which line it fails. I believe we have to blame Thunderbird here as you suspected. It placed a line break because to line was too long. Crap! Why do tools have to be "smart"?
Gr. AvS