git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: t5541: Bad file descriptor

From
Johannes Sixt <j6t@kdbg.org>
Date
May 5, 2011, 20:42 UTC
Message-ID
<4DC30BAF.2060009@kdbg.org>
In-Reply-To
<20110505061845.GC29033@sigill.intra.peff.net>
Am 05.05.2011 08:18, schrieb Jeff King:
Show 10 quoted lines
> OK, embarrassing. 09c9957 completely breaks smart http pushing. My
> testing of Johannes' patch was completely focused on the error case, and
> I didn't have a single test for the non-error case. And on top of that,
> we _have_ nice tests in the test suite to catch this, but obviously
> neither I, nor Johannes, nor Junio were running them (because they need
> apache installed and GIT_TEST_HTTPD set).
> 
> Ugh.
> 
> This patch on top of 09c9957 should fix it.
Very embarassing! Thanks for fixing up my mess. The patch looks good.
-- Hannes
Previous: Brian Gernhardt
Message 11 of 11 in “t5541: Bad file descriptor”
  1. Brian GernhardtMay 5, 2011
  2. Junio C HamanoMay 5, 2011
  3. Jeff KingMay 5, 2011
  4. Jeff KingMay 5, 2011
  5. Sverre RabbelierMay 5, 2011
  6. Avery PennarunMay 5, 2011
  7. Sverre RabbelierMay 5, 2011
  8. Jeff KingMay 9, 2011
  9. Jeff KingMay 5, 2011
  10. Brian GernhardtMay 5, 2011
  11. Johannes SixtMay 5, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.