[PATCH 8/9] sparse: Fix some "symbol not declared" warnings
- From
Ramsay Jones <ramsay@ramsay1.demon.co.uk>
- Date
- Apr 7, 2011, 18:49 UTC
- Message-ID
- <4D9E073D.5090006@ramsay1.demon.co.uk>
In particular, sparse issues the "symbol 'a_symbol' was not declared. Should it be static?" warnings for the following symbols:
attr.c:468:12: 'git_etc_gitattributes'
attr.c:476:5: 'git_attr_system'
vcs-svn/svndump.c:282:6: 'svndump_read'
vcs-svn/svndump.c:417:5: 'svndump_init'
vcs-svn/svndump.c:432:6: 'svndump_deinit'
vcs-svn/svndump.c:445:6: 'svndump_reset'The symbols in attr.c only require file scope, so we add the static modifier to their declaration.
The symbols in vcs-svn/svndump.c are external symbols, and they already have extern declarations in the "svndump.h" header file, so we simply include the header in svndump.c.
Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk> --- attr.c | 4 ++-- vcs-svn/svndump.c | 1 + 2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/attr.c b/attr.c index 0e28ba8..f6b3f7e 100644 --- a/attr.c +++ b/attr.c @@ -465,7 +465,7 @@ static void drop_attr_stack(void) } } -const char *git_etc_gitattributes(void) +static const char *git_etc_gitattributes(void) { static const char *system_wide; if (!system_wide) @@ -473,7 +473,7 @@ const char *git_etc_gitattributes(void) return system_wide; } -int git_attr_system(void) +static int git_attr_system(void) { return !git_env_bool("GIT_ATTR_NOSYSTEM", 0); } diff --git a/vcs-svn/svndump.c b/vcs-svn/svndump.c index 572a995..bc79222 100644 --- a/vcs-svn/svndump.c +++ b/vcs-svn/svndump.c @@ -13,6 +13,7 @@ #include "line_buffer.h" #include "string_pool.h" #include "strbuf.h" +#include "svndump.h" /* * Compare start of string to literal of equal length;
-- 1.7.4