Re: [PATCH 00/10] Docs: git tag

From: Michael J Gruber <git@drmicha.warpmail.net>
Date: Mar 29, 2011, 06:25 UTC
Message-ID: <4D917B5E.1000600@drmicha.warpmail.net>
In-Reply-To: <7v8vvzyvdi.fsf@alter.siamese.dyndns.org>

Junio C Hamano venit, vidit, dixit 28.03.2011 20:04:

Show 22 quoted lines

> Michael Witten <mfwitten@gmail.com> writes:
> 
>> Small patches fixing up the `git tag' docs.
>>
>> Michael Witten (10):
>>   Docs: git tag: Add `the'
>>   Docs: git tag: peoples back -> people's backs
>>   Docs: git tag: Revise a paragraph.
>>   Docs: git tag: other's -> the other person's
>>   Docs: git tag: Streamline a sentence.
>>   Docs: git tag: Add missing 'the'
>>   Docs: git tag: Use 'who' again
>>   Docs: git tag: Remove superfluous 'with'
>>   Docs: git tag: Use semicolon
>>   Docs: git tag: Rewrite discussion of GIT_COMMITTER_DATE
> 
> Thanks; all looked sensible changes, except for 7/10 which I somehow find
> the original is more readable than the new text, partly because the
> sentences are shorter but more importantly because the two sentences make
> two separate assertions (the first is about what "one-shot" pull means,
> the second is about why automatic tag following is not desired in that
> situation).

Looked mostly sensible to me (and I share Junio's view on 7), too, although I probably would have changed "other's" simply to "others'".

And yes, while I like the dramatic sound of "behind peoples' backs", you're absolutely right with "people's", of course:)

Those 10 patches could have been 1 actually, they are really divided into atoms (which is not bad per se) even though they all fall under "cosmetic language corrections and improvements" without any content change nor restructuring.

Michael