Re: [PATCH/RFC 0/3] gitweb: Split gitweb.js, improve JavaScript
- From
J.H. <warthog9@eaglescrag.net>
- Date
- Mar 25, 2011, 22:03 UTC
- Message-ID
- <4D8D112A.5020703@eaglescrag.net>
- In-Reply-To
- <1301089586-8534-1-git-send-email-jnareb@gmail.com>
The only thing I would comment on is that we may want to document (for the build process) a way to force a certain ordering of various files. Case in point we probably want to force the things like various global defs (what I'm proposing in the timezone stuff) at the top and let the function defs go below that.
Other than that this all looks good.
- John 'Warthog9' Hawley
On 03/25/2011 02:46 PM, Jakub Narebski wrote:
Show 28 quoted lines
> This patch series is inspired by patch by John 'Warthog9' Hawley
>
> [PATCH 1/1] gitweb: javascript ability to adjust time based on timezone
> Message-Id: <1300925335-3212-2-git-send-email-warthog9@eaglescrag.net>
> http://thread.gmane.org/gmane.comp.version-control.git/169384/focus=169882
>
> that added a few new JavaScript files for the new feature that this
> patch implemented.
>
> This is marked as RFC mainly because other patches in series,
> especially the last one fixing bug in gitweb's JavaScript code, should
> be send independently on gitweb.js splitting.
>
> Jakub Narebski (3):
> gitweb: Split JavaScript for maintability; concatenate on build
> gitweb: Update and improve comments in JavaScript files
> gitweb: Fix parsing of negative fractional timezones in JavaScript
>
> .gitignore | 1 +
> gitweb/Makefile | 12 +-
> .../static/{gitweb.js => js/blame_incremental.js} | 216 ++------------------
> gitweb/static/js/common-lib.js | 191 +++++++++++++++++
> gitweb/static/js/detect-javascript.js | 44 ++++
> 5 files changed, 261 insertions(+), 203 deletions(-)
> rename gitweb/static/{gitweb.js => js/blame_incremental.js} (75%)
> create mode 100644 gitweb/static/js/common-lib.js
> create mode 100644 gitweb/static/js/detect-javascript.js
>