Re: [PATCH v2] Allow git mv FileA fILEa on case ignore file systems

From: Piotr Krukowiecki <piotr.krukowiecki@gmail.com>
Date: Mar 19, 2011, 19:30 UTC
Message-ID: <4D850466.8040909@gmail.com>
In-Reply-To: <AANLkTimfk8bb-V8Br+KKpoLbA3G3y9HxyfjA=NrsgR0v@mail.gmail.com>

W dniu 19.03.2011 19:20, Erik Faye-Lund pisze:

Show 6 quoted lines

> 2011/3/19 Torsten Bögershausen <tboegi@web.de>:
>> +       if (!(GetFileInformationByHandle(h,&hia)))
>> +               return 0;
>> +  CloseHandle(h);
> 
> Indentation-slip?

I suspect so. CloseHandle line does not use tabs.

Out of curiosity I've roughly counted number of lines that have correct and incorrect indentation.

About 8% (~12600 out of 151000 indented lines) are incorrectly indented. Don't know if that good or bad :)

I have used following to get the numbers:

Bad indentation (includes "Correctly indented comments"): git$ TAB="`echo -e '\t'`" && grep -E "^[ $TAB]* [ $TAB]*[^ $TAB]" *.sh *.[ch] */*.sh */*.[ch] | wc -l 22495

Correctly indented comments: git$ TAB="`echo -e '\t'`" && grep -E "^[ $TAB]* [*]" *.sh *.[ch] */*.sh */*.[ch] | wc -l 9911

Good indentation (does not include "Correctly indented comments"): git$ TAB="`echo -e '\t'`" && grep -E "^$TAB+[^ $TAB]" *.sh *.[ch] */*.sh */*.[ch] | wc -l 128173

-- 
Piotr Krukowiecki