Re: [RFD] git stash over OpenBSD/Linux NFS - cp -p breakage
- From
- Jakob Pfender <jpfender@elegosoft.com>
- Date
- Mar 15, 2011, 12:00 UTC
- Message-ID
- <4D7F54C2.5060500@elegosoft.com>
- In-Reply-To
- <4D7F466A.4090508@viscovery.net>
On 03/15/2011 11:58 AM, Johannes Sixt wrote: > Am 3/15/2011 11:08, schrieb Jakob Pfender: >> We have an NFS setup with Linux machines mounting an NFS that is hosted on >> an OpenBSD server. Recently, we discovered git-stash breaking with: >> >> $ git stash >> cp: preserving permissions for >> `/home/jpfender/stashtest/.git/.git-stash.3056-index': Operation not >> supported >> Cannot save the current worktree state >> >> This was discovered to be caused by a bug in cp that causes 'cp -p' to >> fail in this particular NFS setup - preserving permissions in an NFS >> shared across Linux and OpenBSD machines doesn't work. >> >> I looked at git-stash.sh and could not discover a reason why it had to use >> 'cp -p'. I patched it to use only cp without preserving permissions, and >> everything seemed to work fine. All stash tests succeeded (bar two known >> breakages). >> >> So my question is: Does git-stash really need 'cp -p'? Is it safe to remove? > > Yes. No. > > The timestamp of the index file is important. It is needed to discover > racily-clean index entries. Therefore, the -p must remain.
You're right. The funny thing is: 'cp --preserve=timestamps' works over NFS, 'cp -p' just fails because it wants to copy file ownership as well.
> > You can also try the patch below. Warning: completely untested.
Works fine for me! Also has the advantage that a git tool is used to copy the data, which can interpret the data better than cp could if need arose.
Does anyone want to commit Hannes' patch with the following log message:
Subject: [PATCH] git-stash.sh: Use git-read-tree instead of cp -p
cp -p fails in certain Linux/*BSD NFS setups because it wants to preserve file ownership. However, the reason we use -p is because we want to preserve the timestamp. This can be achieved by using git-read-tree --index-output=<tmp-file>, which copies all the data including the timestamp and avoids using cp -p altogether.
Signed-off-by: Johannes Sixt <j.sixt@viscovery.net> Acked-by: Jakob Pfender <jpfender@elegosoft.com> --- git-stash.sh | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/git-stash.sh b/git-stash.sh index 7561b37..fa62135 100755 --- a/git-stash.sh +++ b/git-stash.sh @@ -82,10 +82,9 @@ create_stash () { # state of the working tree w_tree=$( ( rm -f "$TMP-index" && - cp -p ${GIT_INDEX_FILE-"$GIT_DIR/index"} "$TMP-index" && + git read-tree --index-output="$TMP-index" -m $i_tree && GIT_INDEX_FILE="$TMP-index" && export GIT_INDEX_FILE && - git read-tree -m $i_tree && git diff --name-only -z HEAD | git update-index -z --add --remove --stdin && git write-tree && rm -f "$TMP-index"
-- 1.7.0.4