Re: What's cooking in git.git (Feb 2011, #07; Mon, 28)

From: Johannes Sixt <j.sixt@viscovery.net>
Date: Mar 2, 2011, 06:49 UTC
Message-ID: <4D6DE88F.9030001@viscovery.net>
In-Reply-To: <7voc5uenmy.fsf@alter.siamese.dyndns.org>

Am 3/1/2011 18:50, schrieb Junio C Hamano:

Show 10 quoted lines

> Erik Faye-Lund <kusmabite@gmail.com> writes:
>> There's also the added complication that _open_osfhandle also seems to
>> be limited by this 2048 limit (see the third comment here:
>> http://bugs.mysql.com/bug.php?id=24509). We use this function for
>> pipes and sockets as well. This alone might be a reason to corner-case
>> test the resulting binary on Windows properly.
> 
> As long as the use of osfhandles for non filedescriptors is reasonably
> bounded, it may be enough to make the 25 slop configurable per platform,
> no?

It's not necessary to complicate things. The file descriptors acquired with _open_osfhandle are (only) used in the implementation of pipe() and socket() and count towards the limit no more and no less than the file descriptors acquired with pipe() and socket() on Unix.

-- Hannes