Re: [PATCH] git-gui: add config value gui.diffopts for passing additional diff options

From: Johannes Sixt <j.sixt@viscovery.net>
Date: Jan 28, 2011, 07:29 UTC
Message-ID: <4D42703E.5070202@viscovery.net>
In-Reply-To: <4D420B95.2060509@web.de>

Am 1/28/2011 1:19, schrieb Tilman Vogel:

Show 10 quoted lines

> Am 25.01.2011 01:25, schrieb Pat Thoyts:
>> This seems ok but you don't say what it is for. Why do you want to be
>> able to pass additional options to git diff?
> 
> Sorry, forgot to copy the motivation from
> <https://github.com/git/git/pull/8>:
> 
> I want to be able to make diff ignore whitespace changes "-b". But maybe
> someone else wants "-w" or what not, so I think a generic option field
> is most versatile.

What do you expect to happen, when a user writes any of the following in that edit box?

  --name-status
  -R
  --frotz
  origin master

Don't you want to diagnose bogus input? Disable "Stage/Unstage hung/lines" (because they won't apply anymore)? Etc.

I don't think this is a great improvement. At the least it is not thought through.

-- Hannes