[PATCH] t3419-*.sh: Fix arithmetic expansion syntax error
- From
Ramsay Jones <ramsay@ramsay1.demon.co.uk>
- Date
- Dec 21, 2010, 18:50 UTC
- Message-ID
- <4D10F707.1000206@ramsay1.demon.co.uk>
Some shells, for example dash versions older than 0.5.4, need to spell a variable reference as '$N' rather than 'N' in an arithmetic expansion. In order to avoid the syntax error, we change the offending variable reference from 'i' to '$i' in function scramble.
Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk> ---
Note that this test is unique in having an '#!/bin/bash' line (rather than '#!/bin/sh'), which was (indirectly) responsible for me not noticing this failure for a while. I don't see anything that would require bash, so I suspect this is not intensional.
ATB, Ramsay Jones
t/t3419-rebase-patch-id.sh | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/t/t3419-rebase-patch-id.sh b/t/t3419-rebase-patch-id.sh index 1aee483..6972b49 100755 --- a/t/t3419-rebase-patch-id.sh +++ b/t/t3419-rebase-patch-id.sh @@ -27,7 +27,7 @@ scramble() then echo "$x" fi - i=$(((i+1) % 10)) + i=$((($i+1) % 10)) done < "$1" > "$1.new" mv -f "$1.new" "$1" }
-- 1.7.3