Re: [PATCH 06/14] t9501-*.sh: Fix a test failure on Cygwin

From: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Date: Dec 16, 2010, 19:25 UTC
Message-ID: <4D0A67B7.5010202@ramsay1.demon.co.uk>
In-Reply-To: <201012142004.30322.jnareb@gmail.com>

Jakub Narebski wrote:

Show 13 quoted lines

> Ramsay Jones wrote:
>> The first (setup) test attempts to create a file, using the
>> test_commit function, called 'i can has snapshot?'. On cygwin
>> (and MinGW) this fails with a "No such file or directory" error.
>> In order to fix the tests, we simply remove the '?' wildcard
>> from the name, since the purpose of these tests is not about
>> creating funny filenames.
>>
>> Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
> 
> All right.
> 
> Acked-by: Jakub Narebski <jnareb@gmail.com>

Thanks.

> BTW. if the test was about handling funny filenames (containing
> leading, embedded and trailing space, +&@=<>"' characters), what
> should we do instead?

Hmm... dunno; take a look at t3600-rm.sh and t4135-apply-weird-filenames.sh for inspiration? ;-)

Just FYI the "illegal" pathname characters in windows include:
    < > : " / \ | ? *
along with control chars from 0 - 31.
Also, you can't have any trailing spaces or periods.

ATB, Ramsay Jones