git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 09/19] tree-diff.c: reserve space in "base" for pathname concatenation

From
Johannes Sixt <j.sixt@viscovery.net>
Date
Dec 14, 2010, 08:21 UTC
Message-ID
<4D0728F0.9020807@viscovery.net>
In-Reply-To
<AANLkTimzmq8gUpXUZ801Q+pua_mZMHTJ6wYt_CwcTr3v@mail.gmail.com>
Am 12/14/2010 8:43, schrieb Nguyen Thai Ngoc Duy:
Show 14 quoted lines
> On Tue, Dec 14, 2010 at 2:32 PM, Johannes Sixt <j.sixt@viscovery.net> wrote:
>> Am 12/14/2010 6:32, schrieb Junio C Hamano:
>>> Nguyen Thai Ngoc Duy <pclouds@gmail.com> writes:
>>>
>>>> All paths should not exceed PATH_MAX, right?
>>>
>>> Your PATH_MAX may be a lot shorter than the PATH_MAX on the system I
>>> created my trees on that you are reading.
>>
>> And that is not just gray theory: On Windows, PATH_MAX is whopping 260
>> characters!
> 
> Does that mean Windows won't accept any path longer than that, or
> PATH_MAX is defined just for fun?

It is the limit for path names that we can have without MAJOR extra efforts. It is not a limit implied by the file system.

-- Hannes
Previous: Nguyen Thai Ngoc DuyNext: Nguyen Thai Ngoc Duy
Message 23 of 45 in “nd/struct-pathspec (or pathspec unification [1])”
  1. 00/19 nd/struct-pathspec (or pathspec unification [1])Nguyễn Thái Ngọc Duy, Dec 13, 2010
  2. 01/19 Add struct pathspecNguyễn Thái Ngọc Duy, Dec 13, 2010
  3. Thiago FarinaDec 13, 2010
  4. Nguyen Thai Ngoc DuyDec 14, 2010
  5. 02/19 diff-no-index: use diff_tree_setup_paths()Nguyễn Thái Ngọc Duy, Dec 13, 2010
  6. 03/19 pathspec: cache string length when initializing pathspecNguyễn Thái Ngọc Duy, Dec 13, 2010
  7. 04/19 Convert struct diff_options to use struct pathspecNguyễn Thái Ngọc Duy, Dec 13, 2010
  8. Junio C HamanoDec 13, 2010
  9. Nguyen Thai Ngoc DuyDec 14, 2010
  10. 05/19 tree_entry_interesting(): remove dependency on struct diff_optionsNguyễn Thái Ngọc Duy, Dec 13, 2010
  11. Junio C HamanoDec 13, 2010
  12. 06/19 Move tree_entry_interesting() to tree-walk.c and export itNguyễn Thái Ngọc Duy, Dec 13, 2010
  13. 07/19 glossary: define pathspecNguyễn Thái Ngọc Duy, Dec 13, 2010
  14. 08/19 pathspec: mark wildcard pathspecs from the beginningNguyễn Thái Ngọc Duy, Dec 13, 2010
  15. Junio C HamanoDec 13, 2010
  16. 09/19 tree-diff.c: reserve space in "base" for pathname concatenationNguyễn Thái Ngọc Duy, Dec 13, 2010
  17. Junio C HamanoDec 13, 2010
  18. Nguyen Thai Ngoc DuyDec 14, 2010
  19. Junio C HamanoDec 14, 2010
  20. Nguyen Thai Ngoc DuyDec 14, 2010
  21. Johannes SixtDec 14, 2010
  22. Nguyen Thai Ngoc DuyDec 14, 2010
  23. Johannes SixtDec 14, 2010
  24. Nguyen Thai Ngoc DuyDec 14, 2010
  25. Junio C HamanoDec 14, 2010
  26. 10/19 tree_entry_interesting(): factor out most matching logicNguyễn Thái Ngọc Duy, Dec 13, 2010
  27. Junio C HamanoDec 13, 2010
  28. 11/19 tree_entry_interesting: support depth limitNguyễn Thái Ngọc Duy, Dec 13, 2010
  29. Junio C HamanoDec 13, 2010
  30. Nguyen Thai Ngoc DuyDec 14, 2010
  31. 12/19 tree_entry_interesting(): support wildcard matchingNguyễn Thái Ngọc Duy, Dec 13, 2010
  32. Junio C HamanoDec 13, 2010
  33. Nguyen Thai Ngoc DuyDec 14, 2010
  34. 13/19 tree_entry_interesting(): optimize fnmatch when base is matchedNguyễn Thái Ngọc Duy, Dec 13, 2010
  35. Junio C HamanoDec 13, 2010
  36. 14/19 Convert ce_path_match() use to match_pathspec()Nguyễn Thái Ngọc Duy, Dec 13, 2010
  37. Junio C HamanoDec 13, 2010
  38. Nguyen Thai Ngoc DuyDec 14, 2010
  39. 15/19 pathspec: add match_pathspec_depth()Nguyễn Thái Ngọc Duy, Dec 13, 2010
  40. Junio C HamanoDec 13, 2010
  41. Nguyen Thai Ngoc DuyDec 14, 2010
  42. 16/19 grep: convert to use struct pathspecNguyễn Thái Ngọc Duy, Dec 13, 2010
  43. 17/19 grep: use match_pathspec_depth() for cache/worktree greppingNguyễn Thái Ngọc Duy, Dec 13, 2010
  44. 18/19 grep: use preallocated buffer for grep_tree()Nguyễn Thái Ngọc Duy, Dec 13, 2010
  45. 19/19 grep: drop pathspec_matches() in favor of tree_entry_interesting()Nguyễn Thái Ngọc Duy, Dec 13, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.