git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH/RFC] ident: die on bogus date format

From
Sergio Callegari <sergio.callegari@gmail.com>
Date
Dec 13, 2010, 18:00 UTC
Message-ID
<4D065F4D.1090807@gmail.com>
In-Reply-To
<20101213170225.GA16033@sigill.intra.peff.net>
Thanks for looking (and coding) into it!

For my usage case, a warning would be ok too. If the commit generates a warning, one can notice the warning and --amend the commit.

One can perhaps have the warning now and maybe an error from version 1.8, so: (i) we are sure that the different behavior does not break anything and (ii) there is time to move the fmt_ident up in the code so that it is invoked earlier (to avoid the burden of writing the commit message and then seeing the commit aborted).

By the way, note that I got into the issue by trying to use --date forgetting the time. Don't know if it could make sense to accept the date with some default time in this case.

Regards
Sergio
Previous: Jeff KingNext: Junio C Hamano
Message 3 of 5 in “Git silently ignores --date when data is not in the correct format”
  1. SergioDec 13, 2010
  2. ident: die on bogus date formatJeff King, Dec 13, 2010
  3. Sergio CallegariDec 13, 2010
  4. Junio C HamanoDec 15, 2010
  5. Junio C HamanoDec 21, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.