git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC PATCH 0/2] gitweb: die_error (error handling) improvements

From
J.H. <warthog9@eaglescrag.net>
Date
Dec 13, 2010, 02:17 UTC
Message-ID
<4D058228.7040905@eaglescrag.net>
In-Reply-To
<20101213004259.9475.87376.stgit@localhost.localdomain>
On 12/12/2010 04:46 PM, Jakub Narebski wrote:
Show 6 quoted lines
> The following two patch series changes improve error / exception
> handling in gitweb, preparing the way for gitweb output caching, but
> useful even without it.
> 
> I'm sending this patch series early to gather feedback on possible
> ways of improving error / exception handling in gitweb.

Personally, instead of another band-aid over this problem, and adding (or further legitimizing) goto statements inside gitweb I'd much *MUCH* rather we actually put in the work to actually clean this up.

This is the direction I'm heading in, which I mentioned in an earlier e-mail.

There are a *LOT* of disadvantages to the eval mechanism in perl. It's the standard but gitweb is getting more and more complex, and eval is simplistic. Couple that with the complexity and uncertainty that things like goto add to the code, I would *MUCH* rather not see this series go in, as I think it is the wrong approach to fixing this.

- John 'Warthog9' Hawley
Previous: Jakub NarebskiNext: Jakub Narebski
Message 4 of 6 in “gitweb: die_error (error handling) improvements”
  1. 0/2 gitweb: die_error (error handling) improvementsJakub Narebski, Dec 13, 2010
  2. 1/2 gitweb: Go to DONE_REQUEST rather than DONE_GITWEB in die_errorJakub Narebski, Dec 13, 2010
  3. 2/2 gitweb: use eval + die for error (exception) handlingJakub Narebski, Dec 13, 2010
  4. J.H.Dec 13, 2010
  5. Jakub NarebskiDec 13, 2010
  6. Jakub NarebskiDec 13, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.