Re: Breaking t1510-repo-setup.sh tests in pu
- From
Johannes Sixt <j.sixt@viscovery.net>
- Date
- Nov 26, 2010, 07:51 UTC
- Message-ID
- <4CEF66E8.1050806@viscovery.net>
- In-Reply-To
- <AANLkTim1G__J6KAnd+pNmKWwEDTHexUSJU2E7=7WFZmp@mail.gmail.com>
Am 11/26/2010 3:45, schrieb Nguyen Thai Ngoc Duy:
> OK it's probably bashisms. I think it will pass if you run it with > bash :-P I'll resend the series later without bash specific > constructs.
Sure, it is. This:
GIT_DIR="$TRASH_DIRECTORY/2/.git" test_repo 2/sub
does not work the same way in all shells when test_repo is a shell function. You have to export GIT_DIR explicitly before the function call. (But since in this case, test_repo invokes its own subshell anyway, you better do it in the function.)
-- Hannes