git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/3] GIT-VERSION-GEN: make use of git describe --dirty

From
Mathias Lafeldt <misfire@debugon.org>
Date
Oct 22, 2010, 11:24 UTC
Message-ID
<4CC1745C.70506@debugon.org>
In-Reply-To
<cover.1287746107.git.misfire@debugon.org>

Currently, GIT-VERSION-GEN invokes the plumbing commands "git update-index" and "git diff-index" to determine if the working tree is dirty. It then appends "-dirty" to the version string returned by "git describe".

However, as of Git v1.6.6, "git describe" can be told to do all that with the "--dirty" option, saving us the plumbing.

Signed-off-by: Mathias Lafeldt <misfire@debugon.org>
---
 GIT-VERSION-GEN |    7 ++-----
 1 files changed, 2 insertions(+), 5 deletions(-)
diff --git a/GIT-VERSION-GEN b/GIT-VERSION-GEN
index d441d88..73d5cf9 100755
--- a/GIT-VERSION-GEN
+++ b/GIT-VERSION-GEN
@@ -12,13 +12,10 @@ if test -f version
 then
 	VN=$(cat version) || VN="$DEF_VER"
 elif test -d .git -o -f .git &&
-	VN=$(git describe --match "v[0-9]*" --abbrev=4 HEAD 2>/dev/null) &&
+	VN=$(git describe --match "v[0-9]*" --abbrev=4 --dirty 2>/dev/null) &&
 	case "$VN" in
 	*$LF*) (exit 1) ;;
-	v[0-9]*)
-		git update-index -q --refresh
-		test -z "$(git diff-index --name-only HEAD --)" ||
-		VN="$VN-dirty" ;;
+	v[0-9]*) : ;;
 	esac
 then
 	VN=$(echo "$VN" | sed -e 's/-/./g');
-- 
1.7.3.2
Next: Jonathan Nieder
Message 1 of 7 in “GIT-VERSION-GEN: make use of git describe --dirty”
  1. 1/3 GIT-VERSION-GEN: make use of git describe --dirtyMathias Lafeldt, Oct 22, 2010
  2. Jonathan NiederOct 22, 2010
  3. Mathias LafeldtOct 23, 2010
  4. Mathias LafeldtOct 27, 2010
  5. Jakub NarebskiOct 27, 2010
  6. 2/3 GIT-VERSION-GEN: tweak processing of version fileMathias Lafeldt, Oct 22, 2010
  7. 3/3 GIT-VERSION-GEN: style nitpicksMathias Lafeldt, Oct 22, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.