git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [BUG] git-svn parses --pretty=medium log output, fails when log.decorate is true

From
Mathias Lafeldt <misfire@debugon.org>
Date
Oct 5, 2010, 11:48 UTC
Message-ID
<4CAB1093.7000204@debugon.org>
In-Reply-To
<1286273926.2364.6.camel@wpalmer.simply-domain>
Will Palmer wrote:
Show 15 quoted lines
> I started receiving this error during "git svn dcommit" today:
> 
> Use of uninitialized value $hash in string eq
> at /home/wpalmer/libexec/git-core/git-svn line 1534.
> 
> Examining that section reveals that git-svn is running 
> "git log --no-color --first-parent --pretty=medium"
> 
> and parsing the output in order to find commit hashes and git-svn-id:
> lines. This breaks when log.decorate is true.
> 
> This could be patched-up by adding "--no-decorate" to the options
> git-svn passes, but that seems to me like it would just be adding to the
> pile, as "--pretty=medium" is a moving target. I assume the correct
> solution is to specify the format exactly as it is expected.

I recently submitted a patch adding --no-decorate: http://article.gmane.org/gmane.comp.version-control.git/156919

And it's already in Eric's git-svn branch: git://git.bogomips.org/git-svn

-Mathias
Previous: Will PalmerNext: Jeff King
Message 2 of 5 in “[BUG] git-svn parses --pretty=medium log output, fails when log.decorate is true”
  1. Will PalmerOct 5, 2010
  2. Mathias LafeldtOct 5, 2010
  3. Jeff KingOct 5, 2010
  4. Mathias LafeldtOct 5, 2010
  5. Jeff KingOct 5, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.