git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 3/3 v2] use cache for function names in hunk headers

From
René Scharfe <rene.scharfe@lsrfire.ath.cx>
Date
Sep 26, 2010, 22:17 UTC
Message-ID
<4C9FC668.8070701@lsrfire.ath.cx>
In-Reply-To
<20100926204318.GA19588@localhost>
Am 26.09.2010 22:43, schrieb Clemens Buchacher:
Show 11 quoted lines
> On Sun, Sep 26, 2010 at 06:26:56PM +0200, René Scharfe wrote:
>> -	/*
>> -	 * Be quite stupid about this for now.  Find a line in the old file
>> -	 * before the start of the hunk (and context) which starts with a
>> -	 * plausible character.
>> -	 */
>>
>> It also removes an outdated comment.
> 
> Actually, in the default case, the comment is still correct and
> helpful IMO.

The first sentence was probably written before the match function became configurable. The second one could be moved to def_ff().

Show 5 quoted lines
>> The inlining part should probably split out in its own patch..
> 
> I am not sure what you mean here. Do you want to add the parameter
> funclineprev to the function and remove the function in the next
> page, or do you want to refactor the below into an inline function?

I'd suggest having a first patch for folding xdl_find_func() into xdl_emit_diff() without any functional change (manually inlining it) and a second one for adding funclineprev etc..

René
Previous: Clemens BuchacherNext: Junio C Hamano
Message 11 of 13 in “Patch id tests and diff performance optimization”
  1. Clemens BuchacherSep 19, 2010
  2. 1/3 add rebase patch id testsClemens Buchacher, Sep 19, 2010
  3. 2/3 do not search functions for patch IDClemens Buchacher, Sep 19, 2010
  4. 3/3 use cache for function names in hunk headersClemens Buchacher, Sep 19, 2010
  5. Sverre RabbelierSep 19, 2010
  6. Clemens BuchacherSep 20, 2010
  7. Sverre RabbelierSep 20, 2010
  8. 3/3 use cache for function names in hunk headersClemens Buchacher, Sep 23, 2010
  9. René ScharfeSep 26, 2010
  10. Clemens BuchacherSep 26, 2010
  11. René ScharfeSep 26, 2010
  12. Junio C HamanoSep 27, 2010
  13. Junio C HamanoSep 30, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.