git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] git-svn: fix processing of decorated commit hashes

From
Mathias Lafeldt <misfire@debugon.org>
Date
Sep 23, 2010, 22:05 UTC
Message-ID
<4C9BCF0F.5020101@debugon.org>

The function working_head_info() fails to parse commit hashes if they are decorated (i.e. log.decorate is true), causing dcommit, rebase, and other vital git-svn commands to malfunction.

This patch disables decorated log output with --no-decorate.
Signed-off-by: Mathias Lafeldt <misfire@debugon.org>
---
 git-svn.perl |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/git-svn.perl b/git-svn.perl
index 9b046b6..90e1236 100755
--- a/git-svn.perl
+++ b/git-svn.perl
@@ -1513,7 +1513,7 @@ sub cmt_sha2rev_batch {
 
 sub working_head_info {
 	my ($head, $refs) = @_;
-	my @args = ('log', '--no-color', '--first-parent', '--pretty=medium');
+	my @args = qw/log --no-color --no-decorate --first-parent --pretty=medium/;
 	my ($fh, $ctx) = command_output_pipe(@args, $head);
 	my $hash;
 	my %max;
-- 
1.7.3
Next: Eric Wong
Message 1 of 2 in “git-svn: fix processing of decorated commit hashes”
  1. git-svn: fix processing of decorated commit hashesMathias Lafeldt, Sep 23, 2010
  2. Eric WongSep 24, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.