Re: [PATCHv2] remote-helpers: build in platform independent directory

From: Michael J Gruber <git@drmicha.warpmail.net>
Date: Sep 18, 2010, 12:36 UTC
Message-ID: <4C94B268.2050904@drmicha.warpmail.net>
In-Reply-To: <AANLkTi=ye=Xkz2XaiBaqX3NsZOe0N1NRTaVpPcsSM8o9@mail.gmail.com>

Sverre Rabbelier venit, vidit, dixit 17.09.2010 23:07:

Show 15 quoted lines

> Heya,
> 
> [+Jonathan again]
> 
> On Fri, Sep 17, 2010 at 23:00, Michael J Gruber
> <git@drmicha.warpmail.net> wrote:
>> The solution with setup.cfg avoids this and is cleaner anyways.
> 
> This does feel a lot cleaner, I like this approach better than the v1
> one. I suspect Junio's question still stands though:
> 
> On Fri, Sep 17, 2010 at 20:41, Junio C Hamano <gitster@pobox.com> wrote:
>> Hmm, wouldn't this interfere with the install target if you do not tell
>> the "setup.py install" where your built stuff lives?
>

No, it addresses that also. Maybe my note after the boiler plate was not clear enough, but the "build" setting in setup.cfg also governs the build phase of "setup.py install". Install would work with v1 also but would possibly create another dir during the build phase, with v2 both build phases (that of the build subcommand as well as that of the install subcommand) use the same setting.

Michael