Re: [PATCH 2/2] New send-email option smtpserveroptions.
- From
Pascal Obry <pascal.obry@gmail.com>
- Date
- Sep 4, 2010, 16:39 UTC
- Message-ID
- <4C827657.3000508@obry.net>
- In-Reply-To
- <7v4oe5xyxd.fsf@alter.siamese.dyndns.org>
Junio,
>> + --smtp-server-options <int> * Outgoing SMTP server options to use. > > Is it really an int?
Oups! Fixed.
Show 20 quoted lines
>> + unshift (@sendmail_parameters, $smtp_server_options)
>> + if (defined $smtp_server_options);
>> +
>
> I suspect this would not work, unless you are aiming to add just a
> singular $smtp_server_option, as the actual program invocation looks like
> this later in the program:
>
> } elsif ($smtp_server =~ m#^/#) {
> my $pid = open my $sm, '|-';
> defined $pid or die $!;
> if (!$pid) {
> exec($smtp_server, @sendmail_parameters) or die $!;
> }
> print $sm "$header\n$message";
>
> Somebody in the code before this unshift needs to split the single string
> in $smtp_server_options into multiple parameters, or better yet, it needs
> to accept more than one --smtp-server-option=foo --smtp-server-option=bar
> and accumulate them in @smtp_server_options.For sure this is above my expertise in Perl. As I said I have never worked with Perl. If someone gives me some pointers I can give it a try otherwise I surrender :)
Pascal.
-- --|------------------------------------------------------ --| Pascal Obry Team-Ada Member --| 45, rue Gabriel Peri - 78114 Magny Les Hameaux FRANCE --|------------------------------------------------------ --| http://www.obry.net - http://v2p.fr.eu.org --| "The best way to travel is by means of imagination" --| --| gpg --keyserver keys.gnupg.net --recv-key F949BD3B