git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [Patch] Use a default for a bad env config file variable

From
Michael J Gruber <git@drmicha.warpmail.net>
Date
Aug 10, 2010, 16:08 UTC
Message-ID
<4C617975.8000501@drmicha.warpmail.net>
In-Reply-To
<AANLkTi=UCJa9uT5i9TRB9hGsH1D8b9DgB49TPM5k1htQ@mail.gmail.com>
James venit, vidit, dixit 10.08.2010 17:54:
Show 8 quoted lines
> Sorry about that,
> I guess I had only read the README.
> Hope this is better:
> 
> From d29adf8c788b8a747bfd38dd7e10f684de9aa8e9 Mon Sep 17 00:00:00 2001
> From: James Shubin <purpleidea@gmail.com>
> Date: Tue, 10 Aug 2010 10:30:22 -0400
> Subject: [PATCH] Use a default for a bad env config file variable.
Now, make that commit subject
gitweb: Use a default for a bad env config file variable
(i.e. insert "gitweb: ", delete the stop) and you're good to go ;)
Michael
Show 22 quoted lines
> 
> 
> Signed-off-by: James Shubin <purpleidea@gmail.com>
> ---
>  gitweb/gitweb.perl |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
> 
> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
> index 4efeebc..43294e1 100755
> --- a/gitweb/gitweb.perl
> +++ b/gitweb/gitweb.perl
> @@ -605,6 +605,10 @@ sub evaluate_gitweb_config {
>  	} elsif (-e $GITWEB_CONFIG_SYSTEM) {
>  		do $GITWEB_CONFIG_SYSTEM;
>  		die $@ if $@;
> +	# if config file from env is missing, then try the default anyways
> +	} elsif (-e "++GITWEB_CONFIG_SYSTEM++") {
> +		do "++GITWEB_CONFIG_SYSTEM++";
> +		die $@ if $@;
>  	}
>  }
> 
Previous: Jonathan Nieder
Message 9 of 9 in “Use a default for a bad env config file variable”
  1. Use a default for a bad env config file variableJames, Aug 10, 2010
  2. Matthieu MoyAug 10, 2010
  3. JamesAug 10, 2010
  4. Ævar Arnfjörð BjarmasonAug 10, 2010
  5. Gitweb: Use a default for a bad env config file variableJames Shubin, Aug 10, 2010
  6. Jakub NarebskiAug 10, 2010
  7. James ShubinAug 11, 2010
  8. Jonathan NiederAug 11, 2010
  9. Michael J GruberAug 10, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.