Re: [PATCH] filter-branch tests/docs: avoid \t in sed regexes

From: Tomas Carnecky <tom@dbservice.com>
Date: Jul 29, 2010, 14:47 UTC
Message-ID: <4C519498.3000702@dbservice.com>
In-Reply-To: <0bb511ca2d155ea7e37850a78375da1803032d6c.1280409717.git.trast@student.ethz.ch>

On 7/29/10 3:24 PM, Thomas Rast wrote:

Show 14 quoted lines

> Using \t to represent a tab character is not portable beyond GNU sed
> (see e.g. GNU sed's info pages).  Use printf to generate the tab
> instead.
> 
> Signed-off-by: Thomas Rast <trast@student.ethz.ch>
> ---
> 
>  Adam Mercer wrote:
>>> What OS is this?
>> This was on Mac OS X 10.6. Where sed is BSD sed.
> 
> That's very funny however, since it means that nobody should ever have
> had a successful test run on OS X with the preinstalled tools.  What
> gives?

v1.7.2-rc1 on 10.6:

fixed 3 success 6328 failed 0 broken 21 total 6355

*** t7003-filter-branch.sh ***
*   ok 1: setup
*   ok 2: rewrite identically
*   ok 3: result is really identical
*   ok 4: rewrite bare repository identically
*   ok 5: result is really identical
*   ok 6: correct GIT_DIR while using -d
*   ok 7: Fail if commit filter fails
*   ok 8: rewrite, renaming a specific file
*   ok 9: test that the file was renamed
*   ok 10: rewrite, renaming a specific directory
*   ok 11: test that the directory was renamed
*   ok 12: rewrite one branch, keeping a side branch
*   ok 13: common ancestor is still common (unchanged)
*   ok 14: filter subdirectory only
*   ok 15: subdirectory filter result looks okay
*   ok 16: more setup
*   ok 17: use index-filter to move into a subdirectory
*   ok 18: stops when msg filter fails
*   ok 19: author information is preserved
*   ok 20: remove a certain author's commits
*   ok 21: barf on invalid name
*   ok 22: "map" works in commit filter
*   ok 23: Name needing quotes
*   ok 24: Subdirectory filter with disappearing trees
*   ok 25: Tag name filtering retains tag message
*   ok 26: Tag name filtering strips gpg signature
*   ok 27: Tag name filtering allows slashes in tag names
*   ok 28: Prune empty commits
*   ok 29: --remap-to-ancestor with filename filters
*   ok 30: setup submodule
*   ok 31: rewrite submodule with another content
*   ok 32: replace submodule revision