Re: [PATCH] git submodule add: Remove old docs about implicit -f

From: Jens Lehmann <jens.lehmann@web.de>
Date: Jul 17, 2010, 16:26 UTC
Message-ID: <4C41D9A7.7000508@web.de>
In-Reply-To: <1279382025-24814-1-git-send-email-avarab@gmail.com>

Am 17.07.2010 17:53, schrieb Ævar Arnfjörð Bjarmason:

Show 5 quoted lines

> git submodule add no longer implicitly adds with --force. Remove
> references to the old functionality in the documentation.
> 
> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
> ---

> This amended patch removes some obsolete documentation that you
> missed.

Yeah, thanks!

    Acked-by: Jens Lehmann <Jens.Lehmann@web.de>

Show 7 quoted lines

>> +               echo >&2 "The following path is ignored by one of your .gitignore files:" &&
>> +               echo >&2 $path &&
>> +               echo >&2 "Use -f if you really want to add it."
> 
> Is the "it" intentional? We currently say "them" in git add regardless
> of how many things are being added, so perhaps we should say "it"
> there too for singulars.

Yes, the "it" is intentional. While "git add" may be called with one or more files, "git submodule add" can only be called with one path. That's why I chose the singular form here.