Re: [PATCH v2] Add svnrdump

From: C. Michael Pilato <cmpilato@collab.net>
Date: Jul 14, 2010, 17:56 UTC
Message-ID: <4C3DFA3E.7000809@collab.net>
In-Reply-To: <20100714174716.GB2866@burratino>

On 07/14/2010 01:47 PM, Jonathan Nieder wrote:

Show 17 quoted lines

> C. Michael Pilato wrote:
> 
>> Revprops aren't handled by the replay API for any revision.
> 
> Hmm?  What is the rev_props argument to the
> 
> typedef svn_error_t (*svn_ra_replay_revstart_callback_t)(
> 				svn_revnum_t revision,
> 				void *replay_baton,
> 				const svn_delta_editor_t **editor,
> 				void **edit_baton,
> 				apr_hash_t *rev_props,
> 				apr_pool_t *pool)
> 
> callback for, then?
> 
> Using svn_ra_rev_prop() for rev 0 does seem simple enough, though.

Ah, I was talking about the svn_repos_replay() API (which is used by the svn_ra_replay() API). It definitely makes sense to me that the RA's replay API be able to report the revprops for revision 0.

Sorry for the confusion.

-- 
C. Michael Pilato <cmpilato@collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand