Re: [PATCH] git-svn: mangle refnames forbidden in git

From: Michael J Gruber <git@drmicha.warpmail.net>
Date: Jul 8, 2010, 18:53 UTC
Message-ID: <4C361EB5.7010704@drmicha.warpmail.net>
In-Reply-To: <20100708130315.GA1529@burratino>

Jonathan Nieder venit, vidit, dixit 08.07.2010 15:03:

Show 15 quoted lines

> Eric Wong wrote:
> 
>> I can't reproduce it with 1.5.1 here, does URI-escaping the "@{0}"
>> to "%40%7B0%7D" work?
> 
> Yes.
> 
>  ...
>  $ svn cp -m reflog file:///tmp/foo/source 'file:///tmp/foo/not-a%40%7B0%7Dreflog'
>  Committed revision 2.
>  $ (cd wc && svn update)
>  A    not-a@{0}reflog
>  Updated to revision 2.
> 
> Does that work with svn 1.5.x?

It turns out this is not so much about general escaping but about the treatment of so called svn PEG revisions (not so unsimilar to our @{}).

svn r954995 integrated r952973 (which implemented the eating of PEG revisions) into the 1.6.x branch. It's considered a bug fix.

This "fix" is in 1.6.12 but not in 1.6.11.

Now, git-svn adjusts its behaviour to the svn version for things like info. But I don't know if it's worth doing in this case - maybe we should just change the test not to use the PEG revisions identifier "@".

Michael