Re: [PATCH 2/2] Makefile: work around ksh's failure to handle missing list argument to for loop

From: Michael J Gruber <git@drmicha.warpmail.net>
Date: Jul 4, 2010, 18:37 UTC
Message-ID: <4C30D4D5.3020900@drmicha.warpmail.net>
In-Reply-To: <8YdP-GcDDflOVZnykNVIGceOm01bqeg9PDvdgIfgqUnh29RKC-6Qi8_KBVoqLIt5iyt7g1TX5l96M5KyLrfOqg@cipher.nrlssc.navy.mil>

Brandon Casey venit, vidit, dixit 02.07.2010 20:50:

Show 15 quoted lines

> From: Brandon Casey <drafnel@gmail.com>
> 
> ksh does not like it when the list argument is missing in a for loop.  This
> can happen when NO_CURL is set which causes REMOTE_CURL_ALIASES to be unset.
> In this case, the for loop in the Makefile expands to look like this:
> 
>    for p in ; do
> 
> and ksh complains like this:
> 
>    /bin/ksh: syntax error at line 15 : `;' unexpected
> 
> The existing attempt to work around this issue, introduced by 70b89f87,
> tried to protect the for loop by first testing whether REMOTE_CURL_ALIASES
> was empty, but it does not seem to work.  So adopt Bruce Stephens's

What does that mean? Either it works or it doesn't. I did work back then. Does it (i.e.: the test for emtyness) fail to work for certain shells?

Michael