Re: git-gui and gitk-git as submodules (Re: [RFC PATCH 0/2] Teach "git status" the "--ignore-submodules" option)

From: Marc Branchaud <marcnarc@xiplink.com>
Date: Jun 28, 2010, 18:29 UTC
Message-ID: <4C28EA0A.3080804@xiplink.com>
In-Reply-To: <4C25E83E.4080905@web.de>

On 10-06-26 07:45 AM, Jens Lehmann wrote:

Show 5 quoted lines

> 
> Yes, I think having them as a submodule makes lots of sense. But
> submodules are not there yet. Unless I overlooked something, the
> following issues must be resolved before having these two as a
> submodule, otherwise people will complain (and rightfully so!):

I applaud all the current submodule work -- thanks a ton!

I would like to ask submodule developers to please keep in mind scenarios
where only a subset of the super-project's submodules are in use at one time.
 In particular, please avoid forcing any blanket updates to all submodules.
I think the features being discussed would be much more useful if they only
applied to submodules that are already initialized and updated by the user,
and that any unintialized submodules should be left alone.

> 1) Switching branches, merging, rebasing and resetting in the
>    superproject must result in a checkout of the matching submodule
>    work tree (right now you always have to issue a "git submodule
>    update" afterwards to get the submodules in sync).

So, extending my request to this situation, I would say git should only update submodules that are already initialzied and updated.

> 2) On "git clone" the submodules must be cloned and checked out too
>    (currently you have to do a "git submodule update --init" after
>    cloning the superproject).

Making clone do this automatically would be a show-stopper for us. The current '--recursive' option is fine (though we never use it).

It would be interesting if the super-project could configure which submodules to automatically clone.

(FYI, our build works along the lines of what Jonathan suggested: it instructs folks on how to obtain missing submodules.)

M.