Re: [PATCH] read_cache: cast types from stat to ce_cache

From: Michael J Gruber <git@drmicha.warpmail.net>
Date: Jun 11, 2010, 13:32 UTC
Message-ID: <4C123AD4.6070606@drmicha.warpmail.net>
In-Reply-To: <7vmxv2nar5.fsf@alter.siamese.dyndns.org>

Junio C Hamano venit, vidit, dixit 10.06.2010 17:54:

Show 15 quoted lines

> Michael J Gruber <git@drmicha.warpmail.net> writes:
> 
>> -	ce->ce_dev = st->st_dev;
>> -	ce->ce_ino = st->st_ino;
>> -	ce->ce_uid = st->st_uid;
>> -	ce->ce_gid = st->st_gid;
>> -	ce->ce_size = st->st_size;
>> +	ce->ce_dev = (unsigned int)st->st_dev;
>> +	ce->ce_ino = (unsigned int)st->st_ino;
>> +	ce->ce_uid = (unsigned int)st->st_uid;
>> +	ce->ce_gid = (unsigned int)st->st_gid;
>> +	ce->ce_size = (unsigned int)st->st_size;
> 
> I haven't had my morning coffee yet, but wouldn't the conversion be
> automatic by assignment anyway?

Well, we do cast from dev_t etc. to unsigned int in all other places in read_cache.c.

In any case, enjoy your coffee :)

Michael