Re: [PATCH/RFC v3 0/7] Add internationalization support to Git

From

Johannes Sixt <j.sixt@viscovery.net>

Date

Jun 2, 2010, 06:32 UTC

Message-ID

<4C05FB18.7010200@viscovery.net>

In-Reply-To

<AANLkTimhxqGRPjYz-k5f-LTIk6KajEwUuGJWt-dAKZQT@mail.gmail.com>

Am 6/2/2010 2:11, schrieb Ævar Arnfjörð Bjarmason:

>     +export GIT_TEXTDOMAINDIR=`pwd`/../share/locale

This works only in some shells for two reasons:

- 'export foo=bar' syntax is not understood everywhere;

- if it is understood, then some shells still split the expansion in
'export foo=`pwd`' at white-space.

Use 'foo=bar; export foo', like you did elsewhere.

>      test_expect_success 'sanity: $TEXTDOMAINDIR exists' '
>     -	test -d $TEXTDOMAINDIR
>     +	test -d $TEXTDOMAINDIR &&
>     +	test $TEXTDOMAINDIR = $GIT_TEXTDOMAINDIR

Double-quotes, double-quotes!

-- Hannes