git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Git, Mac OS X and German special characters

From
Michael J Gruber <git@drmicha.warpmail.net>
Date
May 20, 2010, 14:29 UTC
Message-ID
<4BF54744.60602@drmicha.warpmail.net>
In-Reply-To
<4BF5294E.7060206@web.de>
Torsten Bögershausen venit, vidit, dixit 20.05.2010 14:21:
Show 7 quoted lines
> Hej Michael,
> Thanks for the reply.
> 
>> You signed off, but is Markus Kuhn's code from UCS GPL2-licensed?
> Oh, I haven't added any code from Markus here.
> But if my sign off is a problem, we can remove it ;-)
> or move the code to another place. (And utf.c will still have code from UCS)

Your sign-off is fine if you can place the code under the terms of the project.

In your patch there is a line
/* This code is originally from http://www.cl.cam.ac.uk/~mgk25/ucs/ */

but I missed the missing '+' in front - that comment was there before your patch! Sorry for the confusion.

Show 19 quoted lines
> 
>> Also, a few tests would be nice.
> Yes, fully agreed.
> My feeling is, that at least
> "git add", "git mv", "git rm" should be tested.
> I will fix that.
> But as I become more familiar with the git testsuite,
> it becomes more and more clear, that testing the new feature will
> do the same tests as already existing tests.
>  From that point of view, it seems easier to re-use the existing test
> cases and run them twice, once with clean ascii, and second time with
> an internationalized form.
> As not all platforms support utf-8, the internationalized tests may be
> either utf-8, 8859-1, or nothing at all.
>   
> I feel that at least 50% of the test cases should be "internationalized",
> like "git merge", "git pull" etc.
> (And re-writing the tests is a big issue, at least for me as a beginner)
> Anyway, I will make simple tests.

Simple tests are a good start. More importantly (compared to full internationalisation), we need someone running them on Mac OS ;)

Michael
Previous: demerphq
Message 13 of 13 in “Git, Mac OS X and German special characters”
  1. Matthias MoellerMay 20, 2010
  2. Ævar Arnfjörð BjarmasonMay 20, 2010
  3. Michael J GruberMay 20, 2010
  4. demerphqMay 20, 2010
  5. Torsten BögershausenMay 20, 2010
  6. Michael J GruberMay 20, 2010
  7. Jay SoffianMay 20, 2010
  8. Jay SoffianMay 20, 2010
  9. Jay SoffianMay 20, 2010
  10. Matthias MoellerMay 20, 2010
  11. Thomas SingerMay 20, 2010
  12. demerphqMay 20, 2010
  13. Michael J GruberMay 20, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.