Re: [PATCH] gitk: Show notes

From: Michael J Gruber <git@drmicha.warpmail.net>
Date: May 11, 2010, 14:35 UTC
Message-ID: <4BE96B41.7010902@drmicha.warpmail.net>
In-Reply-To: <1273566416-3512-1-git-send-email-kirr@mns.spb.ru>

Kirill Smelkov venit, vidit, dixit 11.05.2010 10:26:

Show 7 quoted lines

> If in git.git I do
> 
>     $ git notes add -m 'This makes status significantly slower with Dokko' \
>         ee6fc514
> 
> then `git log` shows the note...
>

because --show-notes is the default...

> ... but unfortunately gitk does not.

... unless --pretty is given, and gitk uses --pretty.

But what is wrong with gitk --show-notes?

If you mean to adjust gitk's default to log's current default please say so in the commit message. There's no need to include a longish sample output for that.

Also, I don't think proc do_readcommit needs the notes. The other two places use $args, so it might make sense to prepend --show-notes to the arg list in a central place.

Michael