Re: [PATCH 2/2] reflog: ignore expire-unreachable for "HEAD" reflog

From: Johannes Sixt <j.sixt@viscovery.net>
Date: Apr 15, 2010, 08:49 UTC
Message-ID: <4BC6D30F.5020004@viscovery.net>
In-Reply-To: <7vochlkvtg.fsf@alter.siamese.dyndns.org>

Am 4/15/2010 9:40, schrieb Junio C Hamano:

Show 12 quoted lines

> Johannes Sixt <j.sixt@viscovery.net> writes:
> 
>> Does not help what? What is the problem?
> 
> You will lose the record from HEAD reflog that records the fact that you
> were at the tip of "next" less than "reflogexpire" but more than
> "reflogexpireunreachable" time ago, if you run "gc" while on "master".
> 
> Such a pruning does not have much to do with the real reason why
> expireunreachable would be a useful thing (namely, to prune failed
> histories that have been rewound away faster than the history that
> survived from reflog of individual branches).

But what is the benefit?

We expire reflogs so that we can garbage-collect objects. If expire-unreachable is ignored for HEAD, then the objects of failed experiments survive due to HEAD's reflog until reflog.expire is reached. If this is what you want, why do we have expire-unreachable at all?

-- Hannes