git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] gitweb: simplify gitweb.min.* generation and clean-up rules

From
Mark Rada <marada@uwaterloo.ca>
Date
Apr 15, 2010, 04:11 UTC
Message-ID
<4BC691FC.8040401@mailservices.uwaterloo.ca>
In-Reply-To
<4BC689FF.9080308@mailservices.uwaterloo.ca>
On 10-04-14 11:37 PM, Mark Rada wrote:
Show 31 quoted lines
> GITWEB_CSS and GITWEB_JS are meant to be "what URI should the installed
> cgi script use to refer to the stylesheet and JavaScript", never "this
> is the name of the file we are building".
> 
> Lose incorrect assignment to them.
> 
> While we are at it, lose FILES that is used only for "clean" target in a
> misguided way.  "make clean" should try to remove all the potential
> build artifacts regardless of a minor configuration change.  Instead of
> trying to remove only the build product "make clean" would have created
> if it were run without "clean", explicitly list the three potential build
> products for removal.
> 
> In addition, this patch tries to make sure that the scripts are
> regenerated whenever the replacement variables are modified.  For a good
> measure, if you used different JSMIN/CSSMIN since the last time you
> produced minified version of these files, they are regenerated.
> 
> Signed-off-by: Junio C Hamano <gitster@pobox.com>
> Tested-by: Mark Rada <marada@uwaterloo.ca>
> 
> 
> ---
> 
> I gave this a test run:
> 	With just jsmin enabled
> 	With just cssmin enabled
> 	With neither enabled
> 	With both enabled
> 	Overriding GITWEB_JS
> 	Overriding GITWEB_JS and jsmin enabled

I should have mentioned that this these were done successively, without running `make clean', and using the autoconfigure script to set JSMIN/CSSMIN.

-- 
Mark Rada
Previous: Mark RadaNext: Jakub Narebski
Message 2 of 4 in “gitweb: simplify gitweb.min.* generation and clean-up rules”
  1. gitweb: simplify gitweb.min.* generation and clean-up rulesMark Rada, Apr 15, 2010
  2. Mark RadaApr 15, 2010
  3. Jakub NarebskiApr 15, 2010
  4. [PATCHv2] gitweb: simplify gitweb.min.* generation and clean-up rulesMark Rada, Apr 15, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.