git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] Let check_preimage() use memset() to initialize "struct checkout"

From
Jens Lehmann <jens.lehmann@web.de>
Date
Apr 9, 2010, 20:08 UTC
Message-ID
<4BBF8943.40407@web.de>

Every code site except check_preimage() uses either memset() or declares a static instance of "struct checkout" to achieve proper initialization. Lets use memset() instead of explicit initialization of all members here too to be on the safe side in case this structure is expanded someday.

Signed-off-by: Jens Lehmann <Jens.Lehmann@web.de>
---
 builtin/apply.c |    5 +----
 1 files changed, 1 insertions(+), 4 deletions(-)
diff --git a/builtin/apply.c b/builtin/apply.c
index ec755ac..d56cabf 100644
--- a/builtin/apply.c
+++ b/builtin/apply.c
@@ -2821,11 +2821,8 @@ static int check_preimage(struct patch *patch, struct cache_entry **ce, struct s
 		if (stat_ret < 0) {
 			struct checkout costate;
 			/* checkout */
+			memset(&costate, 0, sizeof(costate));
 			costate.base_dir = "";
-			costate.base_dir_len = 0;
-			costate.force = 0;
-			costate.quiet = 0;
-			costate.not_new = 0;
 			costate.refresh_cache = 1;
 			if (checkout_entry(*ce, &costate, NULL) ||
 			    lstat(old_name, st))
-- 
1.7.0.3.517.g0017
Message 1 of 1 in “Let check_preimage() use memset() to initialize "struct checkout"”
  1. Let check_preimage() use memset() to initialize "struct checkout"Jens Lehmann, Apr 9, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.