git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH/RFC] gitk: refresh index before checking for local changes

From
A Large Angry SCM <gitzilla@gmail.com>
Date
Apr 7, 2010, 02:21 UTC
Message-ID
<4BBBEC43.5000100@gmail.com>
In-Reply-To
<20100407004353.GA11346@progeny.tock>
Jonathan Nieder wrote:
Show 11 quoted lines
> Most git porcelain silently refreshes stat-dirty index entries.  Teach
> gitk to, too; this will make the behavior easier to understand when a
> person makes a change to a file and then changes mind and restores the
> old version in her editor of choice.
> 
> This patch does not change the ‘checkout’ code path, since it is
> assumed that the index is already being cleaned in that case.
> 
> Testing is needed to check if this breaks operation with read-only
> access to a repository.
> 

NAK - gitk should not modify a repository and/or working dir unless _explicitly_ prompted to by the user.

If you want a new _non-default_ option setting for gitk, that fine also.
Previous: Jonathan NiederNext: Jonathan Nieder
Message 8 of 15 in “gitk pays too much attention to file timestamps”
  1. Alexander GladyshApr 6, 2010
  2. Markus HeidelbergApr 6, 2010
  3. Jonathan NiederApr 6, 2010
  4. Alexander GladyshApr 6, 2010
  5. gitk: refresh index before checking for local changesJonathan Nieder, Apr 7, 2010
  6. Alexander GladyshApr 7, 2010
  7. Jonathan NiederApr 7, 2010
  8. A Large Angry SCMApr 7, 2010
  9. Jonathan NiederApr 7, 2010
  10. Junio C HamanoApr 7, 2010
  11. A Large Angry SCMApr 7, 2010
  12. Avery PennarunApr 7, 2010
  13. Jon SeymourApr 7, 2010
  14. Avery PennarunApr 6, 2010
  15. Jonathan NiederApr 7, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.