Re: [PATCH] Prompt for a username when an HTTP request 401s

From: René Scharfe <rene.scharfe@lsrfire.ath.cx>
Date: Mar 18, 2010, 23:53 UTC
Message-ID: <4BA2BCFC.9070600@lsrfire.ath.cx>
In-Reply-To: <20100318190309.GC10981@spearce.org>

Am 18.03.2010 20:03, schrieb Shawn O. Pearce:

Show 11 quoted lines

> Scott Chacon <schacon@gmail.com> wrote:
>> +static void get_http_user_name()
>> +{
>> +	user_name = xstrdup(getpass("Username: "));
> 
> Why are we getting the username via a password prompt where echo
> has been disabled?  Traditionally a username field is obtained as
> echoed input.
> 
> Also, this method shouldn't be named get_*() if its returning void.
> Sounds far to funny.  init_http_user_name()?  prompt_for_user_name()?

Or inline the one-liner at its single call-site?

René