git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Regression in `git add' in 1.7's 48ffef966c with a wildcard in .gitignore

From
Michael J Gruber <git@drmicha.warpmail.net>
Date
Mar 8, 2010, 20:06 UTC
Message-ID
<4B9558AA.90907@drmicha.warpmail.net>
In-Reply-To
<51dd1af81003080908i3bc94f27lc99e146bb57993ba@mail.gmail.com>
Ævar Arnfjörð Bjarmason venit, vidit, dixit 08.03.2010 18:08:
Show 13 quoted lines
> I've discovered a regression in git-add the 1.7 release which I can't
> see reported anywhere. It was introduced in
> 48ffef966c762578eb818c0c54a7e11dd054f5db by Junio C Hamano at Fri Jan
> 8 23:05:41 2010.
> 
> The problem is that when you have a .gitignore file with * in it
> git-add will only complain that you're trying to add ignored files if
> they're in the top level of your repository, for files in
> subdirectories it now just silently fails:
> 
>     $ mkdir test && cd test && git init
>     $ echo "*" > .gitignore
>     $ mkdir directory && touch foo directory/foo

Could this possibly be fixed by 13bb0ce (builtin-add: fix exclude handling, 2010-02-28) which is on pu?

Michael
Previous: Ævar Arnfjörð BjarmasonNext: Ævar Arnfjörð Bjarmason
Message 2 of 4 in “Regression in `git add' in 1.7's 48ffef966c with a wildcard in .gitignore”
  1. Ævar Arnfjörð BjarmasonMar 8, 2010
  2. Michael J GruberMar 8, 2010
  3. Ævar Arnfjörð BjarmasonMar 8, 2010
  4. Junio C HamanoMar 8, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.