Re: [PATCH] commit: quote the user name in the example

From: Johannes Sixt <j.sixt@viscovery.net>
Date: Feb 24, 2010, 07:49 UTC
Message-ID: <4B84DA03.1040809@viscovery.net>
In-Reply-To: <1266980049-5835-1-git-send-email-kraai@ftbfs.org>

Matt Kraai schrieb:

Show 11 quoted lines

> If the user runs
> 
>  git config --global user.name Your Name
> 
> as suggested, user.name will be set to "Your".  With this patch, the
> suggested command will be
> 
>  git config --global user.name 'Your Name'
> 
> which will set user.name to "Your Name" and hopefully help users avoid
> the former mistake.

Actually, I would prefer that the suggested command is

  git config --global user.name "Your Name"

i.e., with double-quotes, because then the suggestion is also correct for Windows users who run git from CMD: in this environment, single-quotes do not quote, but double-quotes do.

-- Hannes