Re: [PATCH] Remove .git auto detection from setup_git_env()

From: René Scharfe <rene.scharfe@lsrfire.ath.cx>
Date: Feb 5, 2010, 20:29 UTC
Message-ID: <4B6C7FAE.5070104@lsrfire.ath.cx>
In-Reply-To: <7vljf7a901.fsf@alter.siamese.dyndns.org>

Am 05.02.2010 18:27, schrieb Junio C Hamano:

Show 9 quoted lines

> Junio C Hamano <gitster@pobox.com> writes:
> 
>> This topic started from "We broke 'git grep' in .git directory" and I
>> think it is the sanest to revert 3081623 (grep --no-index: allow use of
>> "git grep" outside a git repository, 2010-01-15) which nobody has used so
>> far in any released version of git, until we sort this out at least.
> 
> Sorry; spoke too fast.  We'd also need to revert the one to git.c (7e62265
> (grep: prepare to run outside of a work tree, 2010-01-15) as well.

Show 8 quoted lines

>  		{ "fsck-objects", cmd_fsck, RUN_SETUP },
>  		{ "gc", cmd_gc, RUN_SETUP },
>  		{ "get-tar-commit-id", cmd_get_tar_commit_id },
> -		{ "grep", cmd_grep, USE_PAGER },
> +		{ "grep", cmd_grep, RUN_SETUP | USE_PAGER },
>  		{ "hash-object", cmd_hash_object },
>  		{ "help", cmd_help },
>  		{ "index-pack", cmd_index_pack },

There is one other command with only the USE_PAGER flag turned on, which also seems to have been broken by the change to remove the RUN_SETUP flag: shortlog. But that was done in March 2008 (abe549e1, "shortlog: do not require to run from inside a git repository"), so it's no regression.

René