git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] push: Use sideband channel for hook messages

From
Johannes Sixt <j.sixt@viscovery.net>
Date
Feb 5, 2010, 15:51 UTC
Message-ID
<4B6C3E9C.7040009@viscovery.net>
In-Reply-To
<20100205153252.GC19255@spearce.org>
Shawn O. Pearce schrieb:
Show 10 quoted lines
> Johannes Sixt <j.sixt@viscovery.net> wrote:
>> What would you think about passing both channels to the async callback,
>> and the communicating parties must agree on which channel they communicate
>> by closing the unused one? It would require slight changes to all current
>> async users, though. (It also requires in the threaded case that we pass
>> dup()s of the pipe channels.)
> 
> Yup, I could do that.  I feel like it might be over-engineering the
> solution a bit.  But I'll respin the patch by splitting it apart,
> and doing a bidirectional async here, since you asked nicely.

I do agree about the over-engineering aspect. I mentioned it because in one patch in the past Erik Faye-Lund also extended the async infrastructure for bidirectional communication to use it in git-daemon (Windows port). Meanwhile, he's abandoned this approach because there were unsurmountable obstacles elsewhere; so if you introduce bidi now, it would not immediately buy us anything.

It's your draw.
-- Hannes
Previous: Shawn O. PearceNext: Erik Faye-Lund
Message 5 of 8 in “push: Use sideband channel for hook messages”
  1. push: Use sideband channel for hook messagesShawn O. Pearce, Feb 5, 2010
  2. Junio C HamanoFeb 5, 2010
  3. Johannes SixtFeb 5, 2010
  4. Shawn O. PearceFeb 5, 2010
  5. Johannes SixtFeb 5, 2010
  6. Erik Faye-LundFeb 5, 2010
  7. Shawn O. PearceFeb 5, 2010
  8. Ilari LiusvaaraFeb 5, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.