Re: [PATCH] builtin-name-rev.c: remove the remaining "typedef struct rev_name" from git.
- From
Stephen Boyd <bebarino@gmail.com>
- Date
- Jan 30, 2010, 07:53 UTC
- Message-ID
- <4B63E56C.5000100@gmail.com>
- In-Reply-To
- <8678db190a73997c7bd757b9d78f0fa9e8721055.1264815015.git.tfransosi@gmail.com>
On 01/29/2010 05:32 PM, Thiago Farina wrote:
Show 6 quoted lines
> @@ -43,7 +43,7 @@ static void name_rev(struct commit *commit,
> }
>
> if (name == NULL) {
> - name = xmalloc(sizeof(rev_name));
> + name = xmalloc(sizeof(struct rev_name));How about sizeof(*name) instead? This way we don't have to change it when the type changes again.