Re: [RFC/PATCH] lockfile: show absolute filename in unable_to_lock_message.

From: Johannes Sixt <j6t@kdbg.org>
Date: Jan 6, 2010, 18:50 UTC
Message-ID: <4B44DB6A.2050804@kdbg.org>
In-Reply-To: <1262797288-23004-1-git-send-email-Matthieu.Moy@imag.fr>

Matthieu Moy schrieb:

Show 6 quoted lines

> -		    path, strerror(err));
> +			    make_absolute_path(path), strerror(err));
>  	} else
> -		strbuf_addf(&buf, "Unable to create '%s.lock': %s", path, strerror(err));
> +		strbuf_addf(&buf, "Unable to create '%s.lock': %s",
> +			    make_absolute_path(path), strerror(err));

Since these are merely informative, wouldn't it be more suitable to use make_nonrelative_path()?

-- Hannes