Re: git fast-import not verifying commit author lines?
- From
- David Reiss <dreiss@facebook.com>
- Date
- Dec 30, 2009, 06:04 UTC
- Message-ID
- <4B3AED66.3030803@facebook.com>
- In-Reply-To
- <20091222150649.GI10687@spearce.org>
>> author <somename> 1261454209 +0000 >> committer <somename> 1261454209 +0000 > a foreign system where the data might not reasonably exist.
But shouldn't there still be an extra space? One to separate "author" from the empty name, and one to separate the empty name from the email? If not, then I think this change should be made. (I couldn't find any authoritative documentation on what constitutes a valid commit object.)
(Sorry, this has been sitting in my outbox for a week.)
--David
diff --git i/Documentation/git-fast-import.txt w/Documentation/git-fast-import.txt index 288032c..6917739 100644 --- i/Documentation/git-fast-import.txt +++ w/Documentation/git-fast-import.txt @@ -312,6 +312,6 @@ change to the project. 'commit' SP <ref> LF mark? - ('author' SP <name> SP LT <email> GT SP <when> LF)? - 'committer' SP <name> SP LT <email> GT SP <when> LF + ('author' (SP <name>)? SP LT <email> GT SP <when> LF)? + 'committer' (SP <name>)? SP LT <email> GT SP <when> LF data ('from' SP <committish> LF)?