Re: [PATCH] git-pull.sh: Fix call to git-merge for new command format

From: Michael J Gruber <git@drmicha.warpmail.net>
Date: Dec 3, 2009, 08:10 UTC
Message-ID: <4B17728D.4070606@drmicha.warpmail.net>
In-Reply-To: <7viqcpgtbf.fsf@alter.siamese.dyndns.org>

Junio C Hamano venit, vidit, dixit 02.12.2009 18:49:

Show 7 quoted lines

> Michael J Gruber <git@drmicha.warpmail.net> writes:
> 
>>> Yes.  Anything that sets GIT_EXEC_PATH correctly can use git-foo form.
>>
>> I know they can. That was in the part you snipped ;)
> 
> You asked about the presense of "a policy", and you got an answer.

I guess that was a language issue (on both sides) then, since "can" could be "is able to" as well as "is allowed to", and I read your answer in the former sense; the latter makes it a policy.

Show 8 quoted lines

>> The questions is: Should they? Should we avoid mixing both forms in one
>> script?
> 
> Should we avoid it?  Yes but not very enthusiastically.  We should make
> sure that new invocations anybody adds use dashless form, but I would
> recommend against a "let's remove use of dashed form" patch _unless_ you
> find a time when the project is really quiet and there is nothing else
> going on.

OK, that's all I wanted to know. Thanks.

Michael